Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix deprecation id for non-string env value #19209

Closed
wants to merge 1 commit into from
Closed

src: fix deprecation id for non-string env value #19209

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@thefourtheye
src: fix deprecation id for non-string env value
132cef0 
This is a follow-up of nodejs#18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 7, 2018
@TimothyGu TimothyGu added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 7, 2018
@TimothyGu
Copy link
Member

Sorry, my bad.

@thefourtheye
Copy link
Contributor Author

CI Run: https://ci.nodejs.org/job/node-test-pull-request/13575/

@TimothyGu
Copy link
Member

TimothyGu commented Mar 7, 2018 •
edited
Loading

linuxONE + linter are passing. For the interest of time I've landed this in 50b1cb3.

@TimothyGu TimothyGu closed this Mar 7, 2018
TimothyGu pushed a commit that referenced this pull request Mar 7, 2018
@thefourtheye @TimothyGu
src: fix deprecation id for non-string env value
50b1cb3 
This is a follow-up of #18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.

PR-URL: #19209
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@thefourtheye thefourtheye deleted the fix-process-dep-number branch March 7, 2018 19:34
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@thefourtheye @MayaLekova
src: fix deprecation id for non-string env value
6b98a6a 
This is a follow-up of nodejs#18990. A new
deprecation id was assigned in it, but it was not reflected in code and
test.

PR-URL: nodejs#19209
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thefourtheye @TimothyGu @joyeecheung @targos @nodejs-github-bot